Report for twigphp/Twig#4623@f415198

This PR adds support for the optional chaining operator (?.) to Twig.

by @shokhaa

Some issues have been detected in this pull request

0
Coding Standard

0
Common Typos

0
File Permissions

0
Merge Commits

2
Exception Messages Formatting

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/twigphp/Twig/4623/f415198d535cf779c24934704c8f19ea41bc6ffc/exception_messages.diff | patch -p0
diff -ru src/ExpressionParser/Infix/OptionalChainExpressionParser.php src/ExpressionParser/Infix/OptionalChainExpressionParser.php
--- src/ExpressionParser/Infix/OptionalChainExpressionParser.php	2025-04-01 10:09:57.363625411 +0000
+++ src/ExpressionParser/Infix/OptionalChainExpressionParser.php	2025-04-01 10:10:01.190635231 +0000
@@ -53,7 +53,7 @@
             ) {
                 $attribute = new ConstantExpression($token->getValue(), $token->getLine());
             } else {
-                throw new SyntaxError(\sprintf('Expected name or number, got value "%s" of type %s.', $token->getValue(), $token->toEnglish()), $token->getLine(), $stream->getSourceContext());
+                throw new SyntaxError(\sprintf('Expected name or number, got value "%s" of type "%s".', $token->getValue(), $token->toEnglish()), $token->getLine(), $stream->getSourceContext());
             }
         }
 
diff -ru src/Extension/CoreExtension.php src/Extension/CoreExtension.php
--- src/Extension/CoreExtension.php	2025-04-01 10:09:57.597626011 +0000
+++ src/Extension/CoreExtension.php	2025-04-01 10:10:01.191635234 +0000
@@ -2090,7 +2090,7 @@
         }
 
         if ($env->hasExtension(SandboxExtension::class) && $env->getExtension(SandboxExtension::class)->isSandboxed()) {
-            throw new RuntimeError(\sprintf('The callable passed to the "%s" %s must be a Closure in sandbox mode.', $thing, $type));
+            throw new RuntimeError(\sprintf('The callable passed to the "%s" "%s" must be a Closure in sandbox mode.', $thing, $type));
         }
 
         trigger_deprecation('twig/twig', '3.15', 'Passing a callable that is not a PHP \Closure as an argument to the "%s" %s is deprecated.', $thing, $type);

0
Usage of void in test files

0
Use ::class whenever possible

0
Deprecation Messages