Release v5.4.38

by @fabpot

Some issues have been detected in this pull request

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory:

curl https://fabbot.io/patch/symfony/symfony/54462/19786ecbaa6440b3c98c5bd6e3dfe59b3cf56f45/cs.diff | patch -p0
diff -ru src/Symfony/Component/HttpKernel/Kernel.php src/Symfony/Component/HttpKernel/Kernel.php
--- src/Symfony/Component/HttpKernel/Kernel.php	2024-04-02 19:56:49.052414869 +0000
+++ src/Symfony/Component/HttpKernel/Kernel.php	2024-04-02 19:56:53.676577720 +0000
@@ -105,9 +105,6 @@
         $this->resetServices = false;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function boot()
     {
         if (true === $this->booted) {
@@ -136,9 +133,6 @@
         $this->booted = true;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function reboot(?string $warmupDir)
     {
         $this->shutdown();
@@ -146,9 +140,6 @@
         $this->boot();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function terminate(Request $request, Response $response)
     {
         if (false === $this->booted) {
@@ -160,9 +151,6 @@
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function shutdown()
     {
         if (false === $this->booted) {
@@ -181,9 +169,6 @@
         $this->resetServices = false;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function handle(Request $request, int $type = HttpKernelInterface::MAIN_REQUEST, bool $catch = true)
     {
         if (!$this->booted) {
@@ -215,17 +200,11 @@
         return $this->container->get('http_kernel');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getBundles()
     {
         return $this->bundles;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getBundle(string $name)
     {
         if (!isset($this->bundles[$name])) {
@@ -235,9 +214,6 @@
         return $this->bundles[$name];
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function locateResource(string $name)
     {
         if ('@' !== $name[0]) {
@@ -262,17 +238,11 @@
         throw new \InvalidArgumentException(sprintf('Unable to find file "%s".', $name));
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getEnvironment()
     {
         return $this->environment;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function isDebug()
     {
         return $this->debug;
@@ -305,9 +275,6 @@
         return $this->projectDir;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getContainer()
     {
         if (!$this->container) {
@@ -325,42 +292,27 @@
         file_put_contents(($this->warmupDir ?: $this->getBuildDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)));
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getStartTime()
     {
         return $this->debug && null !== $this->startTime ? $this->startTime : -\INF;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getCacheDir()
     {
         return $this->getProjectDir().'/var/cache/'.$this->environment;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getBuildDir(): string
     {
         // Returns $this->getCacheDir() for backward compatibility
         return $this->getCacheDir();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getLogDir()
     {
         return $this->getProjectDir().'/var/log';
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getCharset()
     {
         return 'UTF-8';
@@ -601,7 +553,7 @@
         $bundlesMetadata = [];
 
         foreach ($this->bundles as $name => $bundle) {
-            $bundles[$name] = \get_class($bundle);
+            $bundles[$name] = $bundle::class;
             $bundlesMetadata[$name] = [
                 'path' => $bundle->getPath(),
                 'namespace' => $bundle->getNamespace(),

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory:

curl https://fabbot.io/patch/symfony/symfony/54462/19786ecbaa6440b3c98c5bd6e3dfe59b3cf56f45/typos.diff | patch -p0
diff -ru CHANGELOG-5.4.md CHANGELOG-5.4.md
--- CHANGELOG-5.4.md	2024-04-02 19:56:48.615399478 +0000
+++ CHANGELOG-5.4.md	2024-04-02 19:56:54.049590857 +0000
@@ -22,7 +22,7 @@
  * bug #54298 [Filesystem] Fix str_contains deprecation (NeilPeyssard)
  * bug #54248 [Security] Correctly initialize the voter property (aschempp)
  * bug #54201 [Lock] Check the correct SQLSTATE error code for MySQL (edomato)
- * bug #54252 [Lock] compatiblity with redis cluster 7 (bastnic)
+ * bug #54252 [Lock] compatibility with redis cluster 7 (bastnic)
  * bug #54219 [Validator] Allow BICs’ first four characters to be digits (MatTheCat)
  * bug #54239 [Mailer] Fix sendmail transport not handling failure  (aboks)
  * bug #54207 [HttpClient] Lazily initialize CurlClientState (arjenm)
@@ -819,7 +819,7 @@
  * bug #45691 [Mailer] fix: stringify from address for ses+api transport (everyx)
  * bug #45696 Make FormErrorIterator generic (VincentLanglet)
  * bug #45676 [Process] Don't return executable directories in PhpExecutableFinder (fancyweb)
- * bug #45564 [symfony/mailjet-mailer] Fix invalid mailjet error managment (alamirault, fancyweb)
+ * bug #45564 [symfony/mailjet-mailer] Fix invalid mailjet error management (alamirault, fancyweb)
  * bug #45697 [Security] Fix return value of `NullToken::getUser()` (chalasr)
  * bug #45719 typehint of DkimOptions algorithm wrong (markusramsak)
  * bug #45702 [Form] Fix the usage of the Valid constraints in array-based forms (stof)

0
License Headers

Issues that cannot be fixed automatically

in Pull Request Description
  • You must add the standard Symfony pull request contribution header in the description (see https://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request).

0
File Permissions

0
Merge Commits

0
Exception Messages Formatting

0
Usage of void in test files

0
Use ::class whenever possible

0
Deprecation Messages