Report for symfony/symfony#52659@636f008

[CssSelector][Serializer][Translation] [Command] Clean unused code

by @alamirault

Some issues have been detected in this pull request

1
Coding Standard

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/52659/636f0088a3f9256f4b7a9ee1063ac5b618ceb166/cs.diff | patch -p0
diff -ru src/Symfony/Component/Console/Command/Command.php src/Symfony/Component/Console/Command/Command.php
--- src/Symfony/Component/Console/Command/Command.php	2023-11-20 18:45:39.578475833 +0000
+++ src/Symfony/Component/Console/Command/Command.php	2023-11-20 18:45:45.523678077 +0000
@@ -401,8 +401,8 @@
     /**
      * Adds an argument.
      *
-     * @param $mode    The argument mode: InputArgument::REQUIRED or InputArgument::OPTIONAL
-     * @param $default The default value (for InputArgument::OPTIONAL mode only)
+     * @param                                                                               $mode            The argument mode: InputArgument::REQUIRED or InputArgument::OPTIONAL
+     * @param                                                                               $default         The default value (for InputArgument::OPTIONAL mode only)
      * @param array|\Closure(CompletionInput,CompletionSuggestions):list<string|Suggestion> $suggestedValues The values used for input completion
      *
      * @return $this
@@ -420,9 +420,9 @@
     /**
      * Adds an option.
      *
-     * @param $shortcut The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
-     * @param $mode     The option mode: One of the InputOption::VALUE_* constants
-     * @param $default  The default value (must be null for InputOption::VALUE_NONE)
+     * @param                                                                               $shortcut        The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
+     * @param                                                                               $mode            The option mode: One of the InputOption::VALUE_* constants
+     * @param                                                                               $default         The default value (must be null for InputOption::VALUE_NONE)
      * @param array|\Closure(CompletionInput,CompletionSuggestions):list<string|Suggestion> $suggestedValues The values used for input completion
      *
      * @return $this

0
Common Typos

0
License Headers

0
Pull Request Contributor Headers

0
File Permissions

0
Merge Commits

1
Exception Messages Formatting

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/52659/636f0088a3f9256f4b7a9ee1063ac5b618ceb166/exception_messages.diff | patch -p0
diff -ru src/Symfony/Component/Serializer/Encoder/XmlEncoder.php src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
--- src/Symfony/Component/Serializer/Encoder/XmlEncoder.php	2023-11-20 18:45:39.998490121 +0000
+++ src/Symfony/Component/Serializer/Encoder/XmlEncoder.php	2023-11-20 18:45:55.006000645 +0000
@@ -397,7 +397,7 @@
             return $this->appendNode($parentNode, $data, $format, $context, 'data');
         }
 
-        throw new NotEncodableValueException('An unexpected value could not be serialized: '.(!\is_resource($data) ? var_export($data, true) : sprintf('%s resource', get_resource_type($data))));
+        throw new NotEncodableValueException('An unexpected value could not be serialized: '.(!\is_resource($data) ? var_export($data, true) : sprintf('"%s" resource', get_resource_type($data))));
     }
 
     /**

0
Usage of void in test files

0
Use ::class whenever possible

0
Deprecation Messages