Report for symfony/symfony#48839@42b1af1

[BrowserKit] Reinitialize server parameters on restart

by @syl20b

Some issues have been detected in this pull request

1
Coding Standard

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/48839/42b1af103916bc6d3775d034e778627d2f38c25b/cs.diff | patch -p0
diff -ru src/Symfony/Component/BrowserKit/AbstractBrowser.php src/Symfony/Component/BrowserKit/AbstractBrowser.php
--- src/Symfony/Component/BrowserKit/AbstractBrowser.php	2023-05-24 11:09:15.241968817 +0000
+++ src/Symfony/Component/BrowserKit/AbstractBrowser.php	2023-05-24 11:09:18.918184420 +0000
@@ -454,7 +454,7 @@
             foreach ($deprecations ? unserialize($deprecations) : [] as $deprecation) {
                 if ($deprecation[0]) {
                     // unsilenced on purpose
-                    trigger_error($deprecation[1], \E_USER_DEPRECATED);
+                    @trigger_error($deprecation[1], \E_USER_DEPRECATED);
                 } else {
                     @trigger_error($deprecation[1], \E_USER_DEPRECATED);
                 }

0
Common Typos

0
License Headers

0
Pull Request Contributor Headers

0
File Permissions

0
Merge Commits

1
Exception Messages Formatting

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/48839/42b1af103916bc6d3775d034e778627d2f38c25b/exception_messages.diff | patch -p0
diff -ru src/Symfony/Component/BrowserKit/AbstractBrowser.php src/Symfony/Component/BrowserKit/AbstractBrowser.php
--- src/Symfony/Component/BrowserKit/AbstractBrowser.php	2023-05-24 11:09:15.241968817 +0000
+++ src/Symfony/Component/BrowserKit/AbstractBrowser.php	2023-05-24 11:09:22.433390580 +0000
@@ -462,7 +462,7 @@
         }
 
         if (!$process->isSuccessful() || !preg_match('/^O\:\d+\:/', $process->getOutput())) {
-            throw new RuntimeException(sprintf('OUTPUT: %s ERROR OUTPUT: %s.', $process->getOutput(), $process->getErrorOutput()));
+            throw new RuntimeException(sprintf('OUTPUT: "%s" ERROR OUTPUT: "%s".', $process->getOutput(), $process->getErrorOutput()));
         }
 
         return unserialize($process->getOutput());

0
Usage of void in test files

0
Use ::class whenever possible

0
Deprecation Messages