Report for symfony/symfony#40254@c3ac8b4

[WIP] [Messenger] Locate exactly one handler

by @gquemener

Some issues have been detected in this pull request

1
Coding Standard

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/40254/c3ac8b4ef89196c91103374421de675eeca21632/cs.diff | patch -p0
diff -ru src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php
--- src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php	2021-02-19 17:13:45.303854148 +0000
+++ src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php	2021-02-19 17:13:45.694846531 +0000
@@ -12,15 +12,14 @@
 namespace Symfony\Component\Messenger\Tests\Handler;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Bundle\FrameworkBundle\Tests\Fixtures\Messenger\SecondMessage;
 use Symfony\Component\Messenger\Envelope;
-use Symfony\Component\Messenger\Handler\HandlerDescriptor;
-use Symfony\Component\Messenger\Stamp\ReceivedStamp;
-use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
-use Symfony\Component\Messenger\Handler\HandlersLocatorInterface;
-use Symfony\Component\Messenger\Handler\ExactlyOneHandlerLocator;
 use Symfony\Component\Messenger\Exception\MultipleHandlersForMessageException;
-use Symfony\Bundle\FrameworkBundle\Tests\Fixtures\Messenger\SecondMessage;
 use Symfony\Component\Messenger\Exception\NoHandlerForMessageException;
+use Symfony\Component\Messenger\Handler\ExactlyOneHandlerLocator;
+use Symfony\Component\Messenger\Handler\HandlersLocatorInterface;
+use Symfony\Component\Messenger\Stamp\ReceivedStamp;
+use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
 
 class ExactlyOneHandlerLocatorTest extends TestCase
 {

0
Common Typos

0
License Headers

0
Pull Request Contributor Headers

0
File Permissions

0
Merge Commits

0
Exception Messages Formatting

1
Usage of void in test files

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/40254/c3ac8b4ef89196c91103374421de675eeca21632/void_in_tests.diff | patch -p0
diff -ru src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php
--- src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php	2021-02-19 17:13:45.303854148 +0000
+++ src/Symfony/Component/Messenger/Tests/Handler/ExactlyOneHandlerLocatorTest.php	2021-02-19 17:13:46.250835700 +0000
@@ -24,12 +24,12 @@
 
 class ExactlyOneHandlerLocatorTest extends TestCase
 {
-    public function testItIsAHandlerLocator(): void
+    public function testItIsAHandlerLocator()
     {
         $this->assertInstanceOf(HandlersLocatorInterface::class, new ExactlyOneHandlerLocator([]));
     }
 
-    public function testItProvidesAHandler(): void
+    public function testItProvidesAHandler()
     {
         $handler1 = $this->createPartialMock(ExactlyOneHandlerLocatorTestCallable::class, ['__invoke']);
         $handler2 = $this->createPartialMock(ExactlyOneHandlerLocatorTestCallable::class, ['__invoke']);
@@ -56,7 +56,7 @@
         ]);
     }
 
-    public function testItThrowsExceptionWhenNoHandlerMatchesMessage(): void
+    public function testItThrowsExceptionWhenNoHandlerMatchesMessage()
     {
         $this->expectException(NoHandlerForMessageException::class);

0
Use ::class whenever possible