Add types to constructors and private/final/internal methods (Batch I)

by @derrabus

Some issues have been detected in this pull request

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory:

curl https://fabbot.io/patch/symfony/symfony/33519/2ce9cf87878772150a86ec6ab54c450fbf51f496/cs.diff | patch -p0
diff -ru src/Symfony/Component/BrowserKit/Client.php src/Symfony/Component/BrowserKit/Client.php
--- src/Symfony/Component/BrowserKit/Client.php	2019-09-09 14:49:06.797455472 +0000
+++ src/Symfony/Component/BrowserKit/Client.php	2019-09-09 14:49:14.196385326 +0000
@@ -307,8 +307,7 @@
     /**
      * Submits a form.
      *
-     * @param array $values           An array of form field values
-     * @param array $serverParameters An array of server parameters
+     * @param array $values An array of form field values
      *
      * @return Crawler
      */
@@ -457,7 +456,7 @@
             foreach ($deprecations ? unserialize($deprecations) : [] as $deprecation) {
                 if ($deprecation[0]) {
                     // unsilenced on purpose
-                    trigger_error($deprecation[1], E_USER_DEPRECATED);
+                    @trigger_error($deprecation[1], E_USER_DEPRECATED);
                 } else {
                     @trigger_error($deprecation[1], E_USER_DEPRECATED);
                 }

0
Common Typos

0
License Headers

0
Pull Request Contributor Headers

0
File Permissions

0
Merge Commits