Report for symfony/symfony#10699@07ce2f2

Added support for slicing nodes.

by @grafitus

Some issues have been detected in this pull request

1
Coding Standard

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/10699/07ce2f2cb95c5687c255be4082860ad5a42cdb4f/cs.diff | patch -p0
diff -ru src/Symfony/Component/DomCrawler/Crawler.php src/Symfony/Component/DomCrawler/Crawler.php
--- src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:28.837442703 +0000
+++ src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:29.389442706 +0000
@@ -341,10 +341,10 @@
 
     /**
      * Slices the list of nodes by $offset and $length.
-     * 
-     * @param integer $offset 
+     *
+     * @param integer $offset
      * @param integer $length
-     * 
+     *
      * @return Crawler A Crawler instance with the sliced nodes.
      */
     public function slice($offset = 0, $length = -1)

0
Common Typos

0
PHPUnit Optimizations

1
Pull Request Contributor Headers

Issues that cannot be fixed automatically

in Pull Request Description
  • You must add the standard Symfony pull request contribution header in the description (see http://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request).

1
PHP Types

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/10699/07ce2f2cb95c5687c255be4082860ad5a42cdb4f/types.diff | patch -p0
diff -ru src/Symfony/Component/DomCrawler/Crawler.php src/Symfony/Component/DomCrawler/Crawler.php
--- src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:28.837442703 +0000
+++ src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:30.877442703 +0000
@@ -294,7 +294,7 @@
     /**
      * Returns a node given its position in the node list.
      *
-     * @param integer $position The position
+     * @param int     $position The position
      *
      * @return Crawler A new instance of the Crawler with the selected node, or an empty Crawler if it does not exist.
      *
@@ -342,8 +342,8 @@
     /**
      * Slices the list of nodes by $offset and $length.
      * 
-     * @param integer $offset 
-     * @param integer $length
+     * @param int     $offset 
+     * @param int     $length
      * 
      * @return Crawler A Crawler instance with the sliced nodes.
      */
@@ -819,7 +819,7 @@
     }
 
     /**
-     * @param integer $position
+     * @param int     $position
      *
      * @return \DOMElement|null
      */

0
PHPDocs

1
PHP

Issues that can be fixed by applying a patch

Review the proposed patch then download it to apply it manually or execute the following command from the repository root directory: 

curl https://fabbot.io/patch/symfony/symfony/10699/07ce2f2cb95c5687c255be4082860ad5a42cdb4f/php.diff | patch -p0
diff -ru src/Symfony/Component/DomCrawler/Crawler.php src/Symfony/Component/DomCrawler/Crawler.php
--- src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:28.837442703 +0000
+++ src/Symfony/Component/DomCrawler/Crawler.php	2014-04-16 21:22:30.941442703 +0000
@@ -107,7 +107,7 @@
 
         // DOM only for HTML/XML content
         if (!preg_match('/(x|ht)ml/i', $type, $xmlMatches)) {
-            return null;
+            return;
         }
 
         $charset = null;
@@ -831,7 +831,7 @@
             }
         }
 
-        return null;
+        return;
     }
 
     /**